Unable to install using a non-standard port

DavidWakelin · June 8, 2021, 9:22am

I am unable to install when using a URL like http://localhost:8080/setup
It redirects to http://localhost/setup

I presume the core assumes port 80

Any fix for this?

halftrainedharry · June 8, 2021, 9:39am

I don’t think it does. I use http://localhost:8080/ all the time to install MODx and never had a problem.

DavidWakelin · June 8, 2021, 9:42am

It absolutley does:

david@david-wakelin-desktop:/tmp$ wget http://localhost:8080/setup
--2021-06-08 10:41:11--  http://localhost:8080/setup
Resolving localhost (localhost)... 127.0.0.1
Connecting to localhost (localhost)|127.0.0.1|:8080... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: http://localhost/setup/ [following]
--2021-06-08 10:41:11--  http://localhost/setup/
Connecting to localhost (localhost)|127.0.0.1|:80... failed: Connection refused.
Resolving localhost (localhost)... 127.0.0.1
Connecting to localhost (localhost)|127.0.0.1|:80... failed: Connection refused.

This is using a fresh copy of 3.x-dev installed via composer: composer create-project modx/revolution modx-test 3.x-dev

DavidWakelin · June 8, 2021, 9:45am

In fact I can see on line 25 of setup/privisioner/bootstrap.php it removes the port if not 80:

if (isset($_SERVER['SERVER_PORT']) && (string)$_SERVER['SERVER_PORT'] !== '' && $_SERVER['SERVER_PORT'] !== 80) {
    $installBaseUrl = str_replace(':' . $_SERVER['SERVER_PORT'], '', $installBaseUrl);
}

halftrainedharry · June 8, 2021, 10:11am

And the next line should then put the port back in.

github.com

modxcms/revolution/blob/64d057f4eb90ebe9fe8780d98efa822709762f04/setup/provisioner/bootstrap.php#L27

    
      
          
          
if (!MODX_SETUP_INTERFACE_IS_CLI) {
              $https = $_SERVER['HTTP_X_FORWARDED_PROTO'] ?? $_SERVER['HTTPS'] ?? 'off';
              $https = in_array(strtolower((string)$https), ['https', 'on', 'ssl', '1'], true);
          
          
    $installBaseUrl = $https ? 'https://' : 'http://';
              $installBaseUrl .= $_SERVER['HTTP_HOST'];
              if (isset($_SERVER['SERVER_PORT']) && (string)$_SERVER['SERVER_PORT'] !== '' && $_SERVER['SERVER_PORT'] !== 80) {
                  $installBaseUrl = str_replace(':' . $_SERVER['SERVER_PORT'], '', $installBaseUrl);
              }
              $installBaseUrl .= ($_SERVER['SERVER_PORT'] === 80 || ($https !== false || strtolower($https) === 'on')) ? '' : ':' . $_SERVER['SERVER_PORT'];
              $installBaseUrl .= $_SERVER['SCRIPT_NAME'];
              $installBaseUrl = htmlspecialchars($installBaseUrl, ENT_QUOTES, 'utf-8');
              define('MODX_SETUP_URL', $installBaseUrl);
          } else {
              define('MODX_SETUP_URL', '/');
          }
          
          
/*
           * Start validating MODX requirements
           */

So it seems $https is somehow true or on in your case.

DavidWakelin · June 9, 2021, 8:51am

OK, my fault. Had a problem in my Nginx config.