Trouble with extensionPackage object in MODX 3

bobray · September 1, 2022, 5:37am

I’ve been wrestling with trying to make ClassExtender work in MODX 3 for days.

I don’t know if this is a bug, or if I’m doing something wrong.

Calling parseSchema() and createObjectContainer() both work (finally). They create the class files and the DB table. Creating the modExtensionPackage object for my package in the DB works as well.

However, I can’t get the classes to work unless I include my autoloader, and addPackage().

Here’s the record in the modx_extension_packages table:

ID: 8
namespace: "extendeduser"
name: "extendeduser"
package: "extendeduser"
path: "[[++core_path]]components/classextender/model/"
table_prefix: "ext_"

(I would have used the users’ table prefix (e.g., modx_), but it would break existing installs.)

This code in a snippet prints a handful of MODX packages, but does not list the extendeduser package.

 return '<pre>' . print_r($modx->packages, true) . '</pre>';

If I call $modx->addExtensionPackage() instead of using the modExtensionPackage object, things work as expected, and I don’t have to call addPackage() any more, but it’s deprecated.

Either the modExtensionPackage object doesn’t actually work in this situation, or I’m doing something wrong.

I should also mention that when using Xdebug and stepping through the code of $this->_loadExtensionPackages($options); called in $modx->initialize(), things go sideways at line 63 of modExtensionPackage.php when $modx->getCacheManager() fails.

Any help appreciated.

markh · September 1, 2022, 6:53am

Worth linking back to the issue: Update modX.[add|remove]ExtensionPackage to use new modExtensionPackage model · Issue #11463 · modxcms/revolution · GitHub

bobray · September 1, 2022, 7:09am

Agreed, though that’s not a good idea unless MODX will actually load them.

halftrainedharry · September 1, 2022, 9:25am

I can’t reproduce this. When I debug it, $modx->getCacheManager() works fine and the cache file core/cache/namespaces/extension-packages.cache.php is created.

Make sure to create a corresponding record in the table modx_namespaces.

bobray · September 1, 2022, 6:49pm

I’m suspect that you’ve identified the problem. I didn’t create the namespace object because it looked like the namespace was only consulted if the extension package’s path was empty, but maybe it’s necessary for the cacheManager call.

halftrainedharry · September 1, 2022, 7:32pm

Yes, there is an inner join in the query:

github.com

modxcms/revolution/blob/f7bc0133f5f09184418a7ddf6f9b98a3f0decd9e/core/src/Revolution/modCacheManager.php#L468


      
              }
          
              return $results;
          }
          
          public function generateExtensionPackagesCache($cacheKey, array $options = [])
          {
          
              $results = [];
              $c = $this->modx->newQuery(modExtensionPackage::class);
              $c->innerJoin(modNamespace::class, 'Namespace');
              $c->select($this->modx->getSelectColumns(modExtensionPackage::class, 'modExtensionPackage'));
              $c->select([
                  'namespace_path' => 'Namespace.path',
              ]);
              $c->sortby('namespace', 'ASC');
              if ($c->prepare() && $c->stmt->execute()) {
                  $extensionPackages = $c->stmt->fetchAll(PDO::FETCH_ASSOC);
                  foreach ($extensionPackages as $extensionPackage) {
                      $extensionPackage['path'] = str_replace([
                          '[[++core_path]]',

bobray · September 1, 2022, 8:37pm

Good catch. Thanks!!!

The extension package isn’t loaded unless the namespace exists.

Oddly, I’m still seeing the same thing as before in Xdebug. The MODX initialize() function calls _loadExtensionPackages(), where the extension package is still not being loaded. If I’m not in the debugger, the package gets loaded. I think there may be an exception that’s thrown and caught, but not reported.

bobray · September 3, 2022, 8:38pm

This topic was automatically closed 2 days after discussion ended and a solution was marked. New replies are no longer allowed. You can open a new topic by clicking the link icon below the original post or solution and selecting “+ New Topic”.

bobray · September 5, 2022, 6:24am

Everything seems copacetic now that I’ve fixed the schema and created the namespaces. Thanks again for the help.