SOLVED::Problem persists with Gallery 2.0.0 not displaying images in Manager

halftrainedharry · July 12, 2022, 12:42pm

For this specific error the problem is likely in these 2 lines

modxcms/Gallery/blob/1332b39a60ffa36ad2aeeb0d37b99f0ef7635a0e/core/components/gallery/processors/mgr/item/getlist.class.php#L66


      
              $c->select($this->modx->getSelectColumns('galItem','galItem'));
              $c->select(array(
                  'AlbumItems.rank',
                  'album' => 'Album.id',
                  '(
                      SELECT GROUP_CONCAT(Tags.tag) FROM '.$this->modx->getTableName('galTag').' AS Tags
                      WHERE Tags.item = galItem.id
                  ) AS tags'
              ));
              $c->groupBy('id');
              $c->groupBy('rank');
              return $c;
          }
          
          
public function prepareRow(xPDOObject $object) {
              $itemArray = $object->toArray();
              $itemArray['album'] = $this->getProperty('album');
              $itemArray['filename'] = basename($object->get('filename'));
              $imagePath = $object->get('image_path');
              $size = @getimagesize($imagePath);
              if (is_array($size)) {

and

github.com

modxcms/Gallery/blob/1332b39a60ffa36ad2aeeb0d37b99f0ef7635a0e/core/components/gallery/processors/mgr/item/getlist.class.php#L31


      
          */
          /**
          * Get a list of Album Items
          *
          * @package gallery
          * @subpackage processors
          */
          class GalleryItemGetListProcessor extends modObjectGetListProcessor {
             public $classKey = 'galItem';
             public $objectType = 'gallery.item';
             public $defaultSortField = 'rank';
             public $defaultSortDirection = 'ASC';
             public $languageTopics = array('gallery:default');
          
          
   public function initialize() {
                 $this->setDefaultProperties(array(
                     'album' => false,
                 ));
                 if (!$this->getProperty('album',false)) return false;
                 return parent::initialize();
             }

But there are a many other places in the code (lines like $c->sortby('rank','ASC');) where “rank” is used and may create an SQL error in MySQL 8.