SOLVED::Problem persists with Gallery 2.0.0 not displaying images in Manager

9thwave · July 12, 2022, 11:55am

Continuing the discussion from SOLVED::Error 42000 executing statement:

Images are not displayed in the Manager using Gallery 2.0.0 and Modx 2.8.4. I can upload new images and they display on the front end but in the Manager the content simply reads “No files match the specified filter.”

I can’t find in the files where to make any changes to ‘rank’ if this is indeed the issue.
The error I’m getting is:

[2022-07-12 11:49:45] (ERROR in modManagerRequest::prepareResponse @ /home/website/public_html/core/model/modx/modmanagerrequest.class.php : 187) modAction support is deprecated since version 2.3.0. Support for modAction has been replaced with routing based on a namespace and action name. Please update the extra with the namespace gallery to the routing based system.
[2022-07-12 11:49:46] (ERROR @ /home/website/public_html/core/xpdo/om/xpdoobject.class.php : 241) SQL: SELECT `galItem`.`id`, `galItem`.`name`, `galItem`.`filename`, `galItem`.`description`, `galItem`.`mediatype`, `galItem`.`url`, `galItem`.`createdon`, `galItem`.`createdby`, `galItem`.`active`, `galItem`.`duration`, `galItem`.`streamer`, `galItem`.`watermark_pos`, AlbumItems.rank, Album.id AS album, (
                SELECT GROUP_CONCAT(Tags.tag) FROM `modx_gallery_tags` AS Tags
                WHERE Tags.item = galItem.id
            ) AS tags FROM `modx_gallery_items` AS `galItem` JOIN `modx_gallery_album_items` `AlbumItems` ON  ( galItem.id = AlbumItems.item AND `AlbumItems`.`album` = ? )  JOIN `modx_gallery_albums` `Album` ON Album.id = AlbumItems.album LEFT JOIN `modx_gallery_tags` `Tags` ON `galItem`.`id` =  `Tags`.`item` GROUP BY id, rank ORDER BY rank ASC LIMIT 20

Any help appreciated.

halftrainedharry · July 12, 2022, 12:42pm

For this specific error the problem is likely in these 2 lines

github.com

modxcms/Gallery/blob/1332b39a60ffa36ad2aeeb0d37b99f0ef7635a0e/core/components/gallery/processors/mgr/item/getlist.class.php#L66


      
              $c->select($this->modx->getSelectColumns('galItem','galItem'));
              $c->select(array(
                  'AlbumItems.rank',
                  'album' => 'Album.id',
                  '(
                      SELECT GROUP_CONCAT(Tags.tag) FROM '.$this->modx->getTableName('galTag').' AS Tags
                      WHERE Tags.item = galItem.id
                  ) AS tags'
              ));
              $c->groupBy('id');
              $c->groupBy('rank');
              return $c;
          }
          
          
public function prepareRow(xPDOObject $object) {
              $itemArray = $object->toArray();
              $itemArray['album'] = $this->getProperty('album');
              $itemArray['filename'] = basename($object->get('filename'));
              $imagePath = $object->get('image_path');
              $size = @getimagesize($imagePath);
              if (is_array($size)) {

and

github.com

modxcms/Gallery/blob/1332b39a60ffa36ad2aeeb0d37b99f0ef7635a0e/core/components/gallery/processors/mgr/item/getlist.class.php#L31


      
          */
          /**
          * Get a list of Album Items
          *
          * @package gallery
          * @subpackage processors
          */
          class GalleryItemGetListProcessor extends modObjectGetListProcessor {
             public $classKey = 'galItem';
             public $objectType = 'gallery.item';
             public $defaultSortField = 'rank';
             public $defaultSortDirection = 'ASC';
             public $languageTopics = array('gallery:default');
          
          
   public function initialize() {
                 $this->setDefaultProperties(array(
                     'album' => false,
                 ));
                 if (!$this->getProperty('album',false)) return false;
                 return parent::initialize();
             }

But there are a many other places in the code (lines like $c->sortby('rank','ASC');) where “rank” is used and may create an SQL error in MySQL 8.

9thwave · July 12, 2022, 1:20pm

Thanks for the quick response.
Yes, I have found the word ‘rank’ in numerous files but what should I change this to and will changes need to be made to every entry?
Do i need to add the extra backticks?

halftrainedharry · July 12, 2022, 1:39pm

Yes. In the lines above replace $c->groupBy('rank'); with $c->groupBy('`rank`'); and public $defaultSortField = 'rank'; with public $defaultSortField = '`rank`';

The problem with this Gallery extra is, that “rank” is used a lot and the backticks shouldn’t be added to all the occurrences in the code.

For example in this code ->get('rank') has to remain as it is and backticks need to be added to the other occurrences .

github.com

modxcms/Gallery/blob/1332b39a60ffa36ad2aeeb0d37b99f0ef7635a0e/core/components/gallery/processors/mgr/item/sort.class.php#L48-L54


      
          UPDATE {$modx->getTableName('galAlbumItem')}
              SET rank = rank - 1
          WHERE
              album = ".$scriptProperties['album']."
          AND rank < {$target->get('rank')}
          AND rank > {$source->get('rank')}
          AND rank > 0

The simplest fix is probably to change the name of the column in the database tables and then replace all the occurences of “rank” in the code with the new name.

system · July 14, 2022, 3:08pm

This topic was automatically closed 2 days after discussion ended and a solution was marked. New replies are no longer allowed. You can open a new topic by clicking the link icon below the original post or solution and selecting “+ New Topic”.