ResizeImageOnUpload plugin and MODX3

mr.tobe · May 11, 2023, 9:05am

Hello everyone,
Has anyone of you got the plugin “Resize Image On Upload” to work under Modx 3?

I changed the “require_once” path from “/core/model/phpthumb/phpthumb.class.php” to “/core/vendor/james-heinrich/phpthumb/phpthumb.class.php”. This was displayed as an error in the error log. But after the change I have no more errors in the logs but it still doesn’t work properly.

Has anyone had any experience with this?

Alternative question: How do you do that for your customers/authors who are not technically versed that images are reduced in size when uploading?

Looking forward to your answers.

halftrainedharry · May 11, 2023, 10:35am

If the plugin property “log” is set to “Yes”, the plugin “ResizeImageOnUpload” should create a log file for each uploaded image with more information under core/cache/logs/. Maybe take a look at those files to make sure the file paths are correct.

When I test it in MODX 3, the plugin still seems to work.

The only problem I see, is when the image gets renamed on upload (system setting upload_translit = “Yes”). Because of a bug, the plugin code still gets the old file name and therefore can’t find the image file and resize it. To fix it, you may have to apply this pull request:

github.com/modxcms/revolution

Update uploadObjectsToContainer method

modxcms:3.x ← sdrenth:patch-2

opened 01:19PM - 31 May 22 UTC

sdrenth

+3 -1

Update uploadObjectsToContainer so the files array passed to the OnFileManagerUp…load event includes an up-to-date version of $objects. So if a file name has been renamed, $objects passed to the OnFileManagerUpload also reflects these changes. ### What does it do? This ensures that $objects is kept up-to-date after looping through the array. ### Why is it needed? Having an old file name triggered an unforced error in FileSluggy because the old file name was passed instead of the renamed filename. ### How to test Install FileSluggy and try to upload a file with a name such as "Modx - Test.jpg". Now you'll see the unforced error: ``` Error - Modx - Test.jpg: The file is not a regular file and cannot be removed. ``` Even though the file has been uploaded successfully and can also be removed.

mr.tobe · May 12, 2023, 7:38am

Does the plugin really make the images smaller for you? I tested it with a 4.5MB image and after uploading it was over 5MB.

halftrainedharry · May 12, 2023, 8:45am

I tested it with the default settings and an image with the dimensions 3120x4208 pixels (7.04 MB). After the upload it has the dimensions 444x600 pixels and a size of 61.2 KB.

Maybe you could also try this extra:

https://extras.modx.com/package/imageoptimonupload

I never used it. But it’s newer and seems to use an external API to optimize the images.

mr.tobe · May 15, 2023, 7:07am

mhhhh…
I just can’t get it to work properly. Do you have “phpThumbOn” or “pThumb” installed?

halftrainedharry · May 15, 2023, 9:33am

This is irrelevant. The plugin uses the phpThumb PHP library directly.
That’s why you had to change the path to “/core/vendor/james-heinrich/phpthumb/phpthumb.class.php”.

What PHP version are you using?
With PHP 8, I get an error on the line

if (array_key_exists($cur_dir, $config)) {

because $config is null. This seems to be fixed in the Github code:

github.com

Setest/ResizeImageOnUpload/blob/30e01516275f681bf643ff549453caa2c9f599fb/core/components/resizeimageonupload/elements/plugins/plugin.resizeimageonupload.php#L322


      
          	$name = urldecode($file['name']);

          	// проверяем на исключения в имени файла

          	if (!empty($exclude_part_of_name) and (strpos($name, $exclude_part_of_name) !== false)){

          		if ($log) $modx->log(modX::LOG_LEVEL_INFO, "except part of name, return;");

          		return;

          	}

          

          	$extensions = explode(',', strtolower($modx->getOption('upload_images')));

          	if ($log) $modx->log(modX::LOG_LEVEL_INFO, "Allowed extensions: ".implode(",", $extensions));

          	// проверям, что наша категория задана в настройках плагина

          	if ($config && array_key_exists($cur_dir, $config)) {

          		$config = $config[$cur_dir];

          	}

          	else {

          		$config=$config_default;

          	}

          

          	// if ($log) $modx->log(modX::LOG_LEVEL_INFO, print_r($config));

          

          	// путь к файлу, имя файла, расширение

          	// $filename = MODX_BASE_PATH.$cur_dir.$name;

mr.tobe · May 15, 2023, 10:36am

I tested this with php 7.4 - 8.1…
The only error I have in the log is this:
(ERROR @ /core/vendor/james-heinrich/phpthumb/phpthumb.class.php : 1814) PHP warning: getimagesize(/assets/bilder/test/Druckertest-A4.jpg): failed to open stream: No such file or directory

1813                                 ob_start();
1814                                 $getimagesize = getimagesize($this->sourceFilename);
1815                                 $GetImageSizeError = ob_get_contents();

mhhh strange…

If I simply make a call on the website, the images are calculated correctly.
[[!phpthumbof? &input=/assets/img/xxx.jpg &options=&w=640&h=480&zc=1&aoe=0&far=0]]
The images are then located as usual in “/core/cache/phpthumb/”

halftrainedharry · May 15, 2023, 10:41am

So is this path correct? By default it should get converted to lowercase letters!
Does it work if you use a file name with only lowercase letters? Did you apply the pull request I linked above?

mr.tobe · May 15, 2023, 10:50am

Yes I made the change.
Oh, good idea. I’ll try it with lower case letters.
And yes, the path is correct…

mr.tobe · May 15, 2023, 10:54am

Damn, it works with lower case letters now… The problem is that upper case letters are extremely common in our country. Now I just need to get something like “SanitizeUpload” working in Modx3.

halftrainedharry · May 15, 2023, 11:10am

In MODX 3, the names of uploaded images are automatically transliterated, if the system setting upload_translit is set to Yes.

The problem is, that the changes to the file name are not transmitted correctly to the “OnFileManagerUpload” event. But this pull request fixed the issue when I tested it.

github.com/modxcms/revolution

Update uploadObjectsToContainer method

modxcms:3.x ← sdrenth:patch-2

opened 01:19PM - 31 May 22 UTC

sdrenth

+3 -1

Update uploadObjectsToContainer so the files array passed to the OnFileManagerUp…load event includes an up-to-date version of $objects. So if a file name has been renamed, $objects passed to the OnFileManagerUpload also reflects these changes. ### What does it do? This ensures that $objects is kept up-to-date after looping through the array. ### Why is it needed? Having an old file name triggered an unforced error in FileSluggy because the old file name was passed instead of the renamed filename. ### How to test Install FileSluggy and try to upload a file with a name such as "Modx - Test.jpg". Now you'll see the unforced error: ``` Error - Modx - Test.jpg: The file is not a regular file and cannot be removed. ``` Even though the file has been uploaded successfully and can also be removed.