Proxy System Settings still active in MODX3?

jenswittmann · March 2, 2024, 3:21pm

Summary

I try to use proxy_host and proxy_port System Settings, but the Package Manager doesn’t work behind a Proxy. Is it still active in MODX3? When looking into the code, it doesn’t seems so: Code search results · GitHub

Step to reproduce

Set Proxy via System Settings and try to install/update an Extra via Package Installer in the Manager.

Observed behavior

Package Installer don’t work with/without Proxy Settings and don’t get remote data.

Expected behavior

Package Installer should work with Proxy Settings to search and update Extras.

Environment

MODX 3.0.4, Apache, CURL active
Example Script with CURL/file_get_contents works when set with Proxy options.

halftrainedharry · March 2, 2024, 8:59pm

In MODX 2.x the system setting proxy_host was used by the class modRestCurlClient.

github.com

modxcms/revolution/blob/6406c9ea30a5c9e8d1aad9b9bc512e920268a779/core/model/modx/rest/modrestcurlclient.class.php#L184


      
          /**
           * Set up proxy configuration , if specified, to be used with REST request.
           *
           * @param resource $ch The cURL connection resource.
           * @param array $options An array of options
           * @return boolean True if the proxy was setup.
           */
          public function setProxy($ch,array $options = array()) {
              $proxyEnabled = false;
              /* if proxy is set, attempt to use it */
              $proxyHost = $this->modx->getOption('proxy_host',null,'');
              if (!empty($proxyHost)) {
                  $proxyEnabled = curl_setopt($ch, CURLOPT_PROXY,$proxyHost);
                  $proxyPort = $this->modx->getOption('proxy_port',null,'');
                  if (!empty($proxyPort)) {
                      curl_setopt($ch, CURLOPT_PROXYPORT,$proxyPort);
                  }
                  $proxyUserpwd = $this->modx->getOption('proxy_username',null,'');
                  if (!empty($proxyUserpwd)) {
                      $proxyAuthType = $this->modx->getOption('proxy_auth_type',null,'BASIC');
                      $proxyAuthType = $proxyAuthType == 'NTLM' ? CURLAUTH_NTLM : CURLAUTH_BASIC;

In MODX 3, modRestClient was removed and replaced.
And it looks like the proxy settings are now ignored.

jenswittmann · March 2, 2024, 11:52pm

Thank you @halftrainedharry.

I found it only here, where it uses CURL and not the new PSR-7 Service: revolution/core/src/Revolution/Transport/modTransportPackage.php at f197da76b44645172dc3f0eb721961fd4f534c04 · modxcms/revolution · GitHub
Maybe this must be refactored or deleted?

So for now i get some questions on this:

If the Proxy Settings aren’t avaible on MODX3, should we communicate it in the Docs or inside the System Settings Description? In my case, we upgraded from 2.6.5 to 3.0.4. If i know it earlier, maybe i only upgrade until 2.8.6 to use the Proxy without breaking Changes.
Is it possible to add the Proxy back to PSR-7? Maybe a question for @markh.
We run MODX on an Windows Apache Server locally as an Intranet Website and need to go through a Proxy for remote Requests. Maybe its oldschool to define the Proxy Settings inside MODX and would be better to add the Proxy on the Apache Level? But i don’t have any Experience on that. If anyone had, i’m very happy to get some ideas.

markh · March 5, 2024, 2:21pm

I’ve never had to use the proxy functionality so wouldn’t even know where to begin to test it, but there do seem to be approaches out there using middleware.

jenswittmann · March 5, 2024, 4:17pm

Thanks @markh! I update ParseX and UpgradeMODX to use Proxy inside PHP code. But this is not future proof and get deleted ob update For now we disable the Proxy to make MODX work again. I close this, because there are more important things to work on

system · March 7, 2024, 4:17pm

This topic was automatically closed 2 days after discussion ended and a solution was marked. New replies are no longer allowed. You can open a new topic by clicking the link icon below the original post or solution and selecting “+ New Topic”.