Problems in the media browser: not sorting by last modified

mediengaarage · April 11, 2025, 11:28am

Sorting in the media browser does not work. When I select “last modified”, it does not sort the elements by date in descending order, but leaves them unordered. Sorting by file size does work.

ModX 3.1.2
PHP 8.3

halftrainedharry · April 11, 2025, 11:37am

Does the value for the “Last Modified” field display correctly in the media browser?
There has been an issue on Github recently that I couldn’t reproduce.

What values do you use for the system settings manager_date_format and manager_time_format on your MODX installation?

mediengaarage · April 14, 2025, 8:32am

manager_time_format = H:i
manager_date_format = d.m.Y

halftrainedharry · April 14, 2025, 9:57am

It’s a bug in MODX that was introduced with version 3.1.0.

I created a issue for it on Github:

github.com/modxcms/revolution

Incorrect sorting by "Last Modified" in MODX browser

opened 09:49AM - 14 Apr 25 UTC

halftrainedharry

bug

## Bug report ### Summary In the MODX browser the files don't get correctly sort…ed by the "last modified" date, if the system setting `manager_date_format` doesn't have the default value. ### Step to reproduce * Change the system setting `manager_date_format` to `d.m.Y` * Open the MODX browser (menu "Media" -> "Media Browser") * Change the dropdown "Sort By:" to "Last Modfied" * Verify that the order of the files is incorrect ### Environment MODX 3.1.2-pl ### Cause The processor `Browser/Directory/GetFiles` used to return the **timestamp** of a file (in the field "lastmod"). The formatting of the timestamps was done in JS. The sorting of the files was also done in JS using the timestamp. With #16604 the processor now already returns the **formatted time string**. The sorting is done in JS using this already formatted strings.

Basically the files used to be sorted by the timestamp (which is a number).
Now the files get sorted by the already formatted datetime-string. This only works correctly if the default system setting values are used (like Y-m-d for manager_date_format). But fails when other values are used, as the sorting is now alphabetically.