MODX3 and Media Browser Copy File Path

dejaya · May 5, 2022, 1:19pm

Am I being daft or has the option to Copy File Path disappeared from the Media Browser in MODX3?

This was a super-useful feature. IMO.

halftrainedharry · May 5, 2022, 2:55pm

I don’t know, if it was a deliberate decision to remove this, or if this feature was just added to the 2.x branch without considering the 3.x branch.

The lexicon strings and the code are still there:

github.com

modxcms/revolution/blob/cb6f56a19af818ad4d1d62dc0d31b9819aaa876f/manager/assets/modext/widgets/media/modx.browser.js#L216

      
        
                        },scope:this},
                        'success':{fn:function(r) {
                            if (!Ext.isEmpty(r.object.url)) {
                                location.href = MODx.config.connector_url+'?action=Browser/File/Download&download=1&file='+r.object.url+'&HTTP_MODAUTH='+MODx.siteId+'&source='+this.config.source+'&wctx='+MODx.ctx;
                            }
                        },scope:this}
                    }
                });
            }
            
            
,copyRelativePath: function(item,e) {
                var node = this.cm.activeNode;
                var data = this.lookup[node.id];
            
            
    var dummyRelativePathInput = document.createElement("input");
                document.body.appendChild(dummyRelativePathInput);
                dummyRelativePathInput.setAttribute('value', data.pathRelative);
            
            
    dummyRelativePathInput.select();
                document.execCommand("copy");

but there is no corresponding menu item:

github.com

modxcms/revolution/blob/cb6f56a19af818ad4d1d62dc0d31b9819aaa876f/core/src/Revolution/Sources/modMediaSource.php#L2135

      
        
            
            
/**
             * Get the context menu items for a specific file object in the list view
             *
             * @param string $path
             * @param bool $editable
             * @param array $data
             *
             * @return array
             */
            protected function getListFileContextMenu($path, $editable = true, $data = [])
            {
                $canSave = $this->checkPolicy('save');
                $canRemove = $this->checkPolicy('remove');
                $canView = $this->checkPolicy('view');
                $canOpen = !empty($data['urlExternal']) &&
                    (empty($data['visibility']) || $data['visibility'] === Visibility::PUBLIC);
            
            
    $menu = [];
                if ($this->hasPermission('file_update') && $canSave) {
                    if ($editable) {

snowcreative · May 13, 2022, 2:05pm

Click on your file and copy the path at the bottom of the media panel. The old method of right-clicking on an item never copied the full path anyway.

dejaya · May 15, 2022, 8:30pm

Thanks @snowcreative that’s a fair point.

I have clients who are used to using that functionality so it’s just a shame for it to be removed accidentally.