MinifyX Not Generating Minified Files

chrisandy · July 18, 2022, 1:22pm

I’ve just upgraded to MinifyX 2 and I’m not getting the minified .css or .js files - most of the time. Sometimes they show up and then disappear but either way even if they appear to be there, they are not linked to. Modx 2.8.4 PHP 7.4. No errors and no debug info.

&cacheFolder=`assets/minifyx/`
&cacheUrl=`assets/minifyx/`
&cssFilename=`style`
&minifyCss=`1`
&cssPlaceholder=`MinifyX.css`
&debug=`1`
&cssTpl=`tplMinifyXcss`
&forceUpdate=`1`
&jsFilename=`scripts`
&jsPlaceholder=`MinifyX.javascript`
&jsTpl=`tplMinifyXjs`
&minifyJs=`1`
&registerCss=`placeholder`
&registerJs=`placeholder`
&cssSources=`
[[++assets_url]]components/f6/css/foundation.css,
[[++assets_url]]components/f6/css/app.css,
[[++assets_url]]components/f6/css/animate.css,
[[++assets_url]]components/tinyslider/tiny-slider.css
`
&jsSources=`
[[++assets_url]]components/f6/js/vendor/jquery.js,
[[++assets_url]]components/tinyslider/tiny-slider.js,
[[++assets_url]]components/f6/js/vendor/what-input.js,
[[++assets_url]]components/f6/js/vendor/foundation.js,
[[++assets_url]]components/f6/js/app.js
`
]]
[[!+MinifyX.css]]
[[!+MinifyX.javascript]]```

halftrainedharry · July 18, 2022, 2:38pm

Does it work if you change this line in the code

github.com

Jako/MinifyX/blob/882727cb9a2644dce08e7d4ef9813facf5a59b2e/core/components/minifyx/src/Snippets/MinifyXSnippet.php#L96


      
              $this->minifyx->clearAssetFiles();
          }
          
          
$sources = $this->prepareSources();
          foreach ($sources as $type => $value) {
              if (empty($value)) {
                  continue;
              }
          
          
    $register = $this->getProperty('register' . ucfirst($type));
              $placeholder = !empty($this->minifyx->getOption($type . 'Placeholder')) ? $this->minifyx->getOption($type . 'Placeholder') : '';
          
          
    // Prepare source files
              $files = $this->minifyx->prepareFiles($value, $type, $register);
              if ($register == 'startup' || $register == 'default') {
                  // Register files
                  foreach ($files as $file) {
                      if ($type == 'css') {
                          $this->modx->regClientCSS($file);
                      } else {
                          if ($register == 'startup') {

to this?

$placeholder = !empty($this->getProperty($type . 'Placeholder')) ? $this->getProperty($type . 'Placeholder') : '';

chrisandy · July 18, 2022, 2:54pm

Yes it does! Thank you. I’m just a bit nervous that the minified css and js files might randomly disappear again. What did that fix please?

halftrainedharry · July 18, 2022, 3:00pm

I think there is just a bug in the newest version that tries to read the values of the properties &cssPlaceholder and &jsPlaceholder from the wrong place.

But it’s probably a good idea if you open a new issue on github, so that the author of the extra can take a proper look at it.

chrisandy · July 18, 2022, 3:04pm

Thank you - I will. I don’t think &minifyJs and &minifyCss work either - they seem to be ignored.

halftrainedharry · July 18, 2022, 3:09pm

It’s probably the same problem in this line

github.com

Jako/MinifyX/blob/882727cb9a2644dce08e7d4ef9813facf5a59b2e/core/components/minifyx/src/Snippets/MinifyXSnippet.php#L115


      
                  } else {
                      if ($register == 'startup') {
                          $this->modx->regClientStartupScript($file);
                      } else {
                          $this->modx->regClientScript($file);
                      }
                  }
              }
          } else {
              // Get combined asset collection
              $result = $this->minifyx->getAssetCollection($type, $files, $this->minifyx->getOption('minify' . ucfirst($type)));
              $url = $this->minifyx->saveAssetFile($result, $type, '_p');
              $tag = $this->modx->getChunk($this->minifyx->getOption($type . 'Tpl'), [
                  'file' => $url,
              ]);
              switch ($register) {
                  case 'placeholder':
                      if ($placeholder) {
                          $this->modx->setPlaceholder($placeholder, $tag);
                      }
                      break;

Trying to read the value from $this->minifyx->getOption(...) instead of $this->getProperty(...).

$result = $this->minifyx->getAssetCollection($type, $files, $this->getProperty('minify' . ucfirst($type)));

jako · July 18, 2022, 4:21pm

The minifyJs and minifyCss options have to be set by system settings, since they are used by the plugin too. I am not sure about the placeholder, but it can be the same reason. Please look into the docs too.

halftrainedharry · July 18, 2022, 7:51pm

The documentation (Usage - MinifyX) lists all four properties (jsPlaceholder, cssPlaceholder, minifyJs, minifyCss) as properties that “can be used in the snippet call”. But all of them are ignored.

In the system settings section, jsPlaceholder are cssPlaceholder are not mentioned.

Is is theoretically possible to manually add new system settings (minifyx.cssPlaceholder and minifyx.jsPlaceholder) to define the placeholders, but in my opinion this is a bug.

jako · July 18, 2022, 9:58pm

I am currently on vacation and will check that, when I am back. And yes, it looks like a bug for the template options. The minify option is somehow a feature. Maybe it has to be solved/documented different.

jako · August 3, 2022, 2:29pm

The issues are solved with 2.0.1.