Migx php 8.0 nested getimage calls, is it a bug?

1

migx modx 2.8.4 php8.0

php7 works fine but on php 8 i get just a white screen on the front office nothing in error log if I do the following is nested inside this

[[getImageList?
    &tvname=`sometvname`
    &tpl=`parentTpl`
]]

inside parenttpl chunk we got

[[getImageList?
    &tpl=`chunkTpl`
    &value=`[[+somevalue]]`
]]

does not work however in 8 works fine in 7

anyone had similar issues?

busy on a mission upgrading sites to php 8 and modx 3. today i am doing php8

2

oh and [[+somevalue]] is def returning migx json data even in php 8

3

sorry to waste everyoens time it is a cache issue

need to call nested ones in php 8

[[!getImageList?
&tpl=chunkTpl
&value=[[+somevalue]]
]]

strangely in 7 it works

4

Are you sure? This doesn’t make sense.

5

sure no,

but when I call the getImageList nested [[! works [[ does not work just blank screen no error

6

Is there something special (e.g. snippet calls) in the [[+somevalue]] data or just plain text?

If it is indeed a PHP 8 problem, then I don’t see why the problem disappears if the snippet is called uncached.
This just executes the same snippet a little bit later (and then for every subsequent request once again).

7

very wierd…

there are a few call on the page the first one for example is

{“MIGX_id”:“6”,“title”:"

sometext

\n

[ texthere ] ( URLHERE )

“,“image”:“home.jpg”},{“MIGX_id”:“4”,“title”:”",“image”:“pool2.jpg”}]

I just switched back to php7 and site worked fine.
made getimage call uncacheed site works fine
made getimage call cacheed site works fine
switched to php 8 site works fine
clear cache all works fine
save a resource site dies white screen
call the getimage uncached site works fine

8

def some sort of cache problem i upgraded too modx 3 to see if problem presists it does

and it got worse cache never gets cleared. I have to delete the cache folder to see any change happening. I wonder what can cause this must be something on this site as other sites are running fine in modx 3 php8 on same server

9

played with all cache settings and I dotn think its the cache

it seems there is something that MIGX or rather getImage does not lilke in php 8 and modx 3

when you nest 2 getimage calls… together I cant figure it out

10

If you can provide the exact JSON-data and the chunk-templates that cause the problem, I can see if I can reproduce the issue.

And please use code blocks to post the data:

```//3 backticks on a line at the beginning
// CODEBLOCK
```//3 backticks on a line at the end
11

hi already did so if I load

[[!getImageList?
&tpl=chunkTpl
&value=[[+somevalue]]
]]

dies

but if I copy and pate the content of [[+somevalue]] and load that into

[[!getImageList?
&tpl=chunkTpl
&value=paste values of [[+somevalue]]
]]

it works which is strange

I am busy redoing my whole migx setup as there must be an issues somehere in there

12

ok I found the culprit and it might have been a combination of things but I got it to work

Wanted to upgrade site from php7 to php8.1 PLUS upgrade from modx 2.8.3 to 3.0.1

After upgrade everything died, I first thought its getImage, then I thought, its cache or a PHP 7 - 8 issue.

1st problem getImage had was parsing HTML that strange enough worked in php 7 but in php 8 did not parse and I got a white blank screen.

Hence I removed the richtext plugin in migx and change it to a plaintext that is getting cleaned with an output modifier.

Secondly I had way to many bad conditional statements esp if then. According to this great article by jason Tags as the Result or How Conditionals are like Mosquitoes | MODX
I fixed them all and changed them from

[[*field:is=1:then=[[!SomeScript]]:else=[[$SomeChunk]]]]

to this

[[[[*field:is=1:then=!SomeScript:else=$SomeChunk]]]]

this especially got rid of many errors in the template chunk of the nested getImage MIGX

I also applied this fix by joshua that might have fixed more output filter issues

now its working but had to rewrite alot of stuff

thanks for the help everyone

13

Hey @servingpixels, as I’ve made an alternative patch for the parsing issue in 3.0.1, would you be so kind to please try Refactor input filter parsing to properly support nested tags by Mark-H · Pull Request #16288 · modxcms/revolution · GitHub and report back if that still works for your use case?

1 Like
14

thanks I will try it as soon as I get a gap

15

many thanks was that patch added to 3.02?.

it works my side on the sites i been testing.however after testing I upgraded to 3.0.2

also note that I found where some nested tags dont work

bad errors eg

[[*field=1:then=`

[[!getImageList?
&tpl=chunkTpl
&value=[[+someJSONvalue]]
]]

`]]

better no error

[[[[*field:is=1:then=
$SomeChunk
]]]]

SomeChunk
contains
[[!getImageList?
&tpl=chunkTpl
&value=[[+somevalue]]
]]

might be heavier in terms of processing but I dont get errors which are prob due to regex?