Llistbox-multiple with comma in the value does not save (or not set as selected on return)

dimmy · March 25, 2021, 9:33am

I created a migx with a listbox-multiple field. the set the inputoptions to: 1||2,2||3==3,3||4,4==4
All the options are selectable but the values that have a comma in it will not be saved, or at least it will not be selected when you return to edit that entry, I think that it does save in the database.

Now I created a tv also, but there I get the same results, So I think thats its a problem within that ext.Js object?

1 and 4,4 are saved (4,4 is the key not the value, the value is 4 that’s why it is saved)
2,2 and 3 are not saved (3 is not saved because the value is 3,3)

halftrainedharry · March 25, 2021, 11:45am

The problem seems to be, that here in the code all the values are joined into 1 string with a comma as a separator.

github.com

modxcms/revolution/blob/416da5a2b6cd7ff4c270ee2d5a34839057a41493/manager/assets/modext/util/superboxselect.js#L310


            });
            Ext.apply(this,{
                valueField: 'value',
                displayField: 'text',
                classField: 'cls',
                styleField: 'style'
            });
        }
       
        if(transformValues.length){
            this.value = transformValues.join(',');
        }
},
setupFieldButtons : function(){
    this.buttonWrap = this.outerWrapEl.createChild({
        cls: 'x-superboxselect-btns'
    });
    
    this.buttonClear = this.buttonWrap.createChild({
        tag:'div',
        cls: 'x-superboxselect-btn-clear ' + this.clearBtnCls

Later this string is split again to add the existing values to the component.

github.com

modxcms/revolution/blob/416da5a2b6cd7ff4c270ee2d5a34839057a41493/manager/assets/modext/util/superboxselect.js#L1352


 */
addValue : function(value){
    
    if(Ext.isEmpty(value)){
        return;
    }
    
    var values = value;
    if(!Ext.isArray(value)){
        value = '' + value;
        values = value.split(this.valueDelimiter); 
    }
    
    Ext.each(values,function(val){
        var record = this.findRecord(this.valueField, val);
        if(record){
            this.addRecord(record);
        }else if(this.mode === 'remote'){
            this.remoteLookup.push(val);                
        }
    },this);

This obviously fails when the values contain commas.

bobray · March 25, 2021, 5:43pm

I doubt if this will work, but it might be worth a try:

1||"2,2"||3=="3,3"||"4,4"==4

or

1||'2,2'||3=='3,3'||'4,4'==4