We are seeking help testing a significant Pull Request that aims to improve grids in MODX Revolution: PR #16653
This change represents an important enhancement to how grid permissions work in MODX, and we want to ensure it’s thoroughly vetted before inclusion in the upcoming Revolution 3.2.0 release. More eyes on this PR means fewer potential issues making it into the final release!
Background Information
For those interested in understanding the complete context and aims of this improvement, please check out the original PR that provides more detailed information: PR #15919
Why Your Help Matters
Community testing is crucial for catching edge cases and ensuring compatibility across different environments and configurations. Even if you only have a few minutes to test, your contribution can make a meaningful difference.
How to Test This PR
Not sure how to test a Pull Request? We’ve got you covered with these helpful guides:
After testing, please share your results directly on the PR thread or respond here with your findings. Include details about your testing environment and any issues encountered (or confirmation that everything works as expected).
Actually, the active PR covers all of the grids. The original PR submission (which mentions 3 grids) has just been kept on GitHub for reference. Note that when I first started the PR I limited it to those 3 grids because I wanted to demonstrate the changes (which are pretty significant) and get buy-in before diving into the whole job.
For others reading this reply: Because the PR is very large (100 files with changes) a group effort is being asked for
I’m really quite keen to get more involved in MODX testing but I think the Git / PR approach is a huge barrier for a lot of the community. It certainly is for me.
Is it possible that this could be posted as an installation package?
It is 100% a skill worth learning, not just for MODX but for any collaborative development - open source or otherwise. There’s a few MODX-specific oddities, but most of it works for any project that uses git.
I know it all seems complex and daunting, but once you get into it and use the concepts more regularly, it opens up a huge world of possibilities. Definitely worth sticking through the learning curve, and asking questions in the community slack if you get stuck.
Once the PR has been merged it’ll be part of the nightly builds, but I don’t know if that process is set up to allow a nightly build of something that hasn’t been merged yet. And the call here is to hopefully get some more eyes on it before it gets merged.
It’s a fair point, Mark, and I do have good intentions to get more familiar with PRs and Git in general - promise!
I’d still argue that it’s a big barrier for lots of people though - and if you would like to get something tested - you want as many testers as possible.
Loads of MODX users will never delve deeper than the occasional custom snippet - but they could still provide valuable feedback on the user experience.
It could even be argued that MODX and similar tools exist so that people don’t have to learn the murkier under-workings of things!
I have to admit it’s a barrier for me too in terms of time and convenience, even though I use Git almost every day and have done PRs myself.
I wonder if it would be feasible to put up a MODX site somewhere (not at MODX.com) for evaluating PRs. New PRs could be incorporated, and we could log in with our MODX credentials to do the testing. I think we’d get a lot more testers with that approach.
