GoodNews change email address for subscription process

vibedesign · October 11, 2021, 10:22am

I would like to change the email address from which the initial activation and subscription confirmation emails are sent, after a user entered his email in the newsletter form. This currently seems to default to the system setting of emailsender or hopefully mail_smtp_user which both contain the same email, but this is not the one I want to use.

I know you can change the emails individually for each newsletter container resource but this is only being used for sending the actual newsletters and not handling the subscription process.

I had hoped for a setting in the snippet, but there doesn’t seem to be one. Is there another way I can change the email used for handling the subscription process?

MODX 2.8.3-pl
GoodNews 1.5.1-pl2

halftrainedharry · October 11, 2021, 11:46am

I’m not really familiar with GoodNews but it looks like the from address is hard-coded to the emailsender system setting. So I don’t think there is much you can do.

github.com

gadgetto/GoodNews/blob/69ba81bfda6fac12e7ebfc1f7c1a0f28b8f5720e/core/components/goodnews/model/goodnews/goodnewssubscription.class.php#L121

    
      
          public function sendEmail($email, $subject, $properties = array()) {
              $msg = $this->getChunk($properties['tpl'], $properties, $properties['tplType']);
              
              $msgAlt = '';
              if (!empty($properties['tplAlt'])) {
                  $msgAlt = $this->getChunk($properties['tplAlt'], $properties, $properties['tplType']);
              }
          
          
    $this->modx->getService('mail', 'mail.modPHPMailer');
              $this->modx->mail->set(modMail::MAIL_BODY, $msg);
              $this->modx->mail->set(modMail::MAIL_FROM, $this->modx->getOption('emailsender'));
              $this->modx->mail->set(modMail::MAIL_FROM_NAME, $this->modx->getOption('site_name'));
              $this->modx->mail->set(modMail::MAIL_SENDER, $this->modx->getOption('emailsender'));
              $this->modx->mail->set(modMail::MAIL_SUBJECT, $subject);
              if (!empty($msgAlt)) {
                  $this->modx->mail->set(modMail::MAIL_BODY_TEXT, $msgAlt);
              }
              $this->modx->mail->address('to', $email, $email);
              $this->modx->mail->address('reply-to', $this->modx->getOption('emailsender'));
              $this->modx->mail->setHTML(true);

bobray · October 13, 2021, 4:14am

This is a pretty weird suggestion, but I’m guessing that the class is pulled into a snippet or plugin. If you create an emailsender property for that snippet or plugin, it should override the System Setting.

It might have to be done over again whenever you update the package.

vibedesign · October 13, 2021, 1:15pm

Thanks for the suggestion, that might be working indeed, although I think I’ll have to leave it as I don’t want anything that can break through an update later down the road.

bobray · October 13, 2021, 7:38pm

If you made it a Context Setting, User Setting, or UserGroup Setting, it should survive upgrades and should still override the System Setting.