Gitify categories wrongly migrated

camicase82 · October 29, 2024, 3:05pm

Hi, I’m trying to organize the categories inside my project because I have a lot of tvs.

I already did in on my local environment, and it looks like these:

Here another example:

here is a full vid on how the categories are organized at my dev environment:

But after cleaning the database and migrating to a new environment, I don’t get any of the categories and everything gets dumped into another category, and the structure I have on my local gets lost:

For instance, I have this TV on the migrated environment:

and this is the yml file:

as you can see it has the right category on the yml file, but not on modx, Im guessing it could be something related to the fact that gitify is using strings instead of id’s to locate the category, already tried updating the primary key definition on the .gitify file to use the id without luck?

Any ideas would be really appreciated

halftrainedharry · October 29, 2024, 5:29pm

Did you also extract YAML files for the categories (modCategory) in your local environment?

It looks like the code should handle category names correctly:

github.com

modmore/Gitify/blob/5c2dce400955562d3217bd37876a90c40ed47534/src/Command/BuildCommand.php#L475-L479


      
          // Handle string-based category names automagically
          if (isset($data['category']) && !empty($data['category']) && !is_numeric($data['category'])) {
              $catName = $data['category'];
              $data['category'] = $this->getCategoryId($catName);
          }

jenswittmann · October 29, 2024, 5:47pm

Maybe this setting helps?

Here is my .gitify file:

github.com/jenswittmann/MODX-Gitify-Preset

.gitify

83793b17a


      
          categories:
              class: modCategory
              primary: category
              truncate_on_force:
                  - modCategoryClosure
              where:
                  - { category: Layout }
          templates:
              class: modTemplate
              primary: templatename
              extension: .html
          # template_variables:
          #     class: modTemplateVar
          #     primary: name

camicase82 · October 29, 2024, 6:22pm

Hi there @halftrainedharry thanks for answering, and yes, I also extract the categories, I think the issue is that we have duplicated names for categories, for instance, we have things like definitions under several sections of the app

jenswittmann · October 29, 2024, 6:28pm

Would the Categories ID be a better solution than the name as a string? So the Name can be set multiple times.

halftrainedharry · October 29, 2024, 7:39pm

Yes, if you have a whole tree of categories and some categories with different parents have the same name, if would make sense that the import breaks.

As only the category-name gets stored in the YAML file, the information about the parent is lost.

github.com

modmore/Gitify/blob/5c2dce400955562d3217bd37876a90c40ed47534/src/Command/ExtractCommand.php#L414-L423


      
          public function getCategoryName($id) {
              if (isset($this->categories[$id])) return $this->categories[$id];
          
              $category = $this->modx->getObject('modCategory', $id);
              if ($category) {
                  $this->categories[$id] = $category->get('category');
                  return $this->categories[$id];
              }
              return '';
          }

Relying instead on the category-ID may also create problems, as the same category may have a different ID on the new system (as this is an auto-increment column).

To solve this issue, you probably have to change the code (extract & build), to output the whole “path” of the category (category-name of all the parents + category-name of the child) instead of just the name.