Exif Read Data - file not supported

chrisandy · March 25, 2023, 11:44am

Error log is filling up with the following message in MODX 3.0.3 and PHP 8.1…

[2023-03-24 11:33:37] (ERROR @ /var/www/vhosts/hos-tingdotcom/httpdocs/core/src/Revolution/Sources/modMediaSource.php : 2242) PHP warning: exif_read_data(my-image-name.png): File not supported

excavator · April 12, 2023, 12:03pm

Same thing happening for me, with same versions.
It doesn’t happen with all images, in my case the problem was with an old PNG, created with Adobe ImageReady (or at least that’s what was in meta).

pranawebdesign · April 14, 2023, 12:59am

Have you guys implemented a solution at all ?

It’s happening to me too, on .webp images and the occasional .png as well.

I think I will need to fix it (even if it’s a hack) as I can’t allow the logs to get too bloated…

bruno17 · April 14, 2023, 4:34am

if you are asking for a solution, not to fill the the error log, you can try to set the systemsettings
log_level and debug to 0

chrisandy · April 14, 2023, 6:06am

Thank you but I’d like to know if anyone has a solution to fix the actual error?

halftrainedharry · April 14, 2023, 6:41am

It’s not really an error, just a warning that gets logged.
It occurs here in the code:

github.com

modxcms/revolution/blob/69a7d6d14f84151ced04a552678657456c05b9cc/core/src/Revolution/Sources/modMediaSource.php#L2260


      
          } catch (Exception $E) {
              $timestamp = 0;
          }
          
          if ($bases['pathIsRelative']) {
              $absolute_path = $bases['pathAbsolute'] . $path;
          } else {
              $absolute_path = $path;
          }
          if (function_exists('exif_read_data')) {
              $exif = @exif_read_data($absolute_path);
              if (!empty($exif) && array_key_exists('Orientation', $exif) && $exif['Orientation'] >= 5) {
                  // This image was rotated
                  $new_width = $size['height'];
                  $new_height = $size['width'];
                  $size['width'] = $new_width;
                  $size['height'] = $new_height;
              }
          }
          // get original image size for proportional scaling
          if ($size['width'] > $size['height']) {

Theoretically, the @ (the error control operator) in front of the function should suppress any errors.

You could add an if statement to the code, to only run exif_read_data for certain image types. There exists a variable $ext with the image extension.

bobray · July 9, 2023, 8:19pm

A custom error handler could filter out these error messages, but it seems like overkill for the issue.

The logo for the CustomSearch extra causes this error message every time the page is loaded, yet the image looks fine. Is there some good reason that MODX is pulling exif information for every image, even though it’s likely that some images will cause this error message?

collst256678 · October 6, 2023, 2:18pm

3.0.4.
The same problem. PHP warning: exif_read_data

dcmoody · November 7, 2023, 10:05pm

It’s happening for me too…

snowcreative · January 3, 2024, 11:00pm

It’s not just with old images. PNGs generated with current versions of Photoshop and Affinity software produce the same error. Images displayed on the front end don’t generate the error for me; it seems confined to viewing images in the Media Manager.

bobray · January 5, 2024, 12:27am

This would eliminate the error message for .png files, but I suspect it might cause other errors without some other changes to the code.:

if (strpos($absolute_path, '.png') === false) {
     $exif = @exif_read_data($absolute_path);
}

excavator · March 28, 2024, 12:42pm

Has anyone figured out what’s causing this?