Content block conditional render [[+nested:is=`1`:then=` `]] not working

smarterShowsJu · January 24, 2023, 4:58pm

Hi , Thanks in advance for reading this post.
I have just updated modX 2.8 to 3.0.3 but this if else statement is not working on my content block
[[+nested:is=1:then= ]]
rather showing as hardcoded text
Has anyone got a solution ?
Cheers

halftrainedharry · January 24, 2023, 5:07pm

There have been several problems with output modifiers in MODX 3.
In MODX 3.0.3, there is still one that’s not fixed. It occurs when there are single square brackets in the code.

Maybe try applying this pull request and see if that fixes the issue:

github.com/modxcms/revolution

[3.0.2] Fix parsing modifiers when encountering literal brackets

modxcms:3.x ← Mark-H:302-fix-brackets

opened 01:51PM - 17 Nov 22 UTC

Mark-H

+139 -5

### What does it do? Fix where literal brackets (not intended as an opening/clo…sing tag) go in the parsed command modifiers. ### Why is it needed? John MacDonald reported the parser breaking in the following scenario: ``` [[++google_analytics:notempty=` <script async src="https://www.googletagmanager.com/gtag/js?id=[[++google_analytics]]"></script> <script> window.dataLayer = window.dataLayer || []; function gtag(){dataLayer.push(arguments);} gtag('js', new Date()); gtag('config', '[[++google_analytics]]'); </script> `]] ``` Rather than outputting the script, it returned just the value of `[[++google_analytics]]`. That test case was simplified to ```[[+tag:notempty=`[]`]]``` as the literal brackets appeared to be the problem. Internally, the command ended up as `notempty[]` with an empty modifier. The `notempty[]` command doesn't exist so the original value is returned in its place. By using the `$inModifier` flag (which gets set in the switch case for ``` ` ``` when depth is 0) the brackets are parsed into the modifiers as they should. ### How to test See tests for examples. Feel free to come up with more complex cases. ### Related issue(s)/PR(s) Reported via Slack. Introduced with #16288 in 3.0.2.

smarterShowsJu · January 25, 2023, 2:17pm

Thanks for the reply , it looks like we don’t have a modParserTes.php in the ModX folder present in our server .
Any idea how come or how to go about it ?
Thanks in advance.

halftrainedharry · January 25, 2023, 2:22pm

Ignore the “modParserTest.php” file in the pull request.

The important part is the other file (core/src/Revolution/Filters/modInputFilter.php) that should be updated.