Can't get wildcard URL working with CustomRequest

snowcreative · July 5, 2024, 9:58pm

I’ve got CustomRequest working fine with a specified resource, but can’t get it to work use a wildcard URL rather than a specific resource.

Ideally, I want this URL,and any other URLs that end with “speaker-info”, to strip off the last bit and send it as a request variable, “speakernamelink”. :

[mysitedomain]/2024/speaker-info/Speaker%20Name

The config I used was:

That wasn’t working so I tried this config:,

and expected this URL to work:
[mysitedomain]/2024/speaker-info/speakername/Speaker%20Name

but it doesn’t. What am I missing?

CustomRequest 1.3.9, MODX 2.8.7

halftrainedharry · July 7, 2024, 8:00pm

Your first solution (Alias Path = #.*?\/speaker-info# | URI Parameter = ["speakernamelink"]) should work.

If you have a resource with “alias” = speaker-info and “Container” = true, a request to https://yourdomain.com/2024/speaker-info/SpeakerName is forwarded to https://yourdomain.com/2024/speaker-info/ and the parameter “speakernamelink” is set to SpeakerName.

snowcreative · July 9, 2024, 3:37pm

“Container” has to be true??

Update:
Yes, “container” has to be true! But why? It doesn’t have to be true if you specify a resource in the settings. The correct resource now loads. But, with “container” set to true, this also works: #.*?speaker-info# (without the initial slash).

halftrainedharry · July 9, 2024, 4:02pm

When the code tries to find a matching resource, it adds a trailing slash to the alias (see the line of code linked below). I don’t know exactly why. But a trailing slash does also get added to container URLs (see column uri in the database table modx_site_content).

github.com

Jako/CustomRequest/blob/d31c7e03c8e415a6712ee19c35e436568e631e6a/core/components/customrequest/src/CustomRequest.php#L306


      
                      'regEx' => $request['regEx'],
                      // Set the found regEx
                      'contextKey' => $request['contextKey']
                  ];
                  $valid = true;
                  break;
              }
          } else {
              if (preg_match($request['alias'], $search, $matches)) {
                  $alias = trim(str_replace($matches[1], '', $matches[0]), '/');
                  $resourceId = $this->modx->findResource($alias . '/', $request['contextKey']);
                  if ($resourceId) {
                      $this->found = [
                          // Strip alias from seached string and urldecode it
                          'urlParams' => urldecode(substr($search, strlen($matches[0]))),
                          // Set the found resource id
                          'resourceId' => $resourceId,
                          // Set the found alias
                          'alias' => $request['alias'],
                          // Set the found regEx
                          'regEx' => $request['regEx'],

Maybe the code should be altered to also search for the alias without the trailing slash.