Babel: TVs are not being synced between languages

bsandoz · May 16, 2024, 3:28pm

Hello,
I am trying to synchronize template variables between different languages/contexts, but I’ve had no luck trying to get this to work so far.

I have entered the TV’s ID in the babel.syncTvs system setting and linked two resources with “Copy synchronized TVs to target” enabled, but when I change the TV’s value in one resource, the value in the linked resource is not updated.

There’s no relevant errors showing up in the log as far as I can tell. For testing purposes, I have written a plugin which should write a message to the log when OnBabelTVSynced is invoked, but there is nothing showing up (if I change the plugin to be triggered by OnBabelLink instead for example, the message does show up).

MODX version is 3.0.4-pl, Babel version is 3.3.2-pl.

halftrainedharry · May 16, 2024, 4:37pm

I believe the problem is here in the code:

github.com

mikrobi/babel/blob/24568f6a817b8c2b6b3a794460500d8c7cc0ca51/core/components/babel/src/Babel.php#L154


      
          $this->packageName = $this->modx->lexicon('babel');
          
          // Add default config
          $this->config = array_merge($this->config, [
              'debug' => $this->getBooleanOption('debug', [], false),
              'modxversion' => $modxversion['version'],
              'permissions' => $this->getPermissions(),
              'contextKeys' => $this->modx->getOption($this->namespace . '.contextKeys', null, ''),
              'restrictToGroup' => $this->getBooleanOption('restrictToGroup', [], true),
              'displayText' => $this->modx->getOption($this->namespace . '.displayText', null, 'language'),
              'syncTvs' => $this->getExplodeSeparatedOption($this->namespace . '.syncTvs', [], ''),
              'babelTvName' => $this->modx->getOption($this->namespace . '.babelTvName', null, 'babelLanguageLinks'),
          ]);
          
          $contextKeys = $this->getOption('contextKeys');
          $this->contextKeyToGroup = $this->decodeContextKeySetting($contextKeys);
          $this->config['contexts'] = array_keys($this->contextKeyToGroup);
          
          $babelTvName = $this->getOption('babelTvName');
          $this->babelTv = $modx->getObject('modTemplateVar', ['name' => $babelTvName]);
          if (!$this->babelTv) {

The code adds the namespace (= babel) to the parameter in the call to “getExplodeSeparatedOption”. Then later the namespace gets added ones again (meaning the code looks up the system setting babel.babel.syncTvs instead of babel.syncTvs):

github.com

mikrobi/babel/blob/24568f6a817b8c2b6b3a794460500d8c7cc0ca51/core/components/babel/src/Babel.php#L201-L202


      
          } elseif (array_key_exists("$this->namespace.$key", $this->modx->config)) {
              $option = $this->modx->getOption("$this->namespace.$key");

So try changing line 154 to this instead:

'syncTvs' => $this->getExplodeSeparatedOption('syncTvs', [], ''),

bsandoz · May 17, 2024, 7:40am

Yes, that seems to have solved the issue! Thank you for your help

jako · May 18, 2024, 8:10am

Babel 3.3.3 is available.

system · May 20, 2024, 8:10am

This topic was automatically closed 2 days after discussion ended and a solution was marked. New replies are no longer allowed. You can open a new topic by clicking the link icon below the original post or solution and selecting “+ New Topic”.