3.1.0 Issue with ACE Editor fullscreen

General
1

Hello,

since upgrade to 3.1.0 there is an issue with ACE Code Editor fullscreen:

grafik
grafik1060×206 19.4 KB

Left side bar still showing…

I reinstalled ACE Extra, but with no effect.

Any idea?

Thank you in advance
bye
Chris

2

Yes, this is a bug in MODX 3.1.0.

It has been mentioned in this issue

and there is already a pull request to fix it:

3

oh, thank you for quick reply.

:pray:

4

Try Monaco MODX. I just started using it recently. It is based on the Visual Studio Code editor.

5

Hello,
in file assets\components\ace\modx.texteditor.js, on line 308 .ace_maximized
in you change value in top: 60px; left: 70px; right: 3px; bottom: 3px;
you should see something like image below.
where the left bar, the element name and the action buttons are visible

immagine
immagine2541×778 60 KB

6

Very nice.
I’m trying it.
In console it gives me 5 errors:
TypeError: WorkerGlobalScope.fetch: /assets/components/monaco/vs/language/css/cssWorker.js is not a valid URL.
Uncaught Error: WorkerGlobalScope.fetch: /assets/components/monaco/vs/language/css/cssWorker.js is not a valid URL.

with some warnin “source Map error”

Is it only my problem?
Is it problem in local dev (wamp)?

7

I got Javascript errors too [sorry I can’t remember what they were] which broke some Extra CMP pages - ConsentFriend, for example.

So I had to uninstall it.

It did look nice though!

8

Damn, too bad I had already customized it for myself

immagine
immagine2559×1239 195 KB

I will uninstall it, waiting for fixes.
Thanks.

9

@fritzkola hello!

Please check https://github.com/modx-pro/modx-ace/releases/download/v1.9.9/ace-1.9.9-pl.transport.zip

10

Hello,

thank you very much.

Great, the bug is fixed.

But one thing makes problems. In full size mode saving with STRG+S no longer runs reliably.

bye

Chris