Why NewsPublisher Wouldn't Show Tabs (For Me)

wpicotte · November 30, 2021, 10:10pm

For a couple days, I’ve been trying to determine why NewsPublisher would not generate tabs, with relevant options enabled via the snippet’s tab parameters.

The issue turned out to be the use of a space between words within a tab title.

For example, a tab is named “Tab-One” is fine. A tab entitled “Tab One”, not so much.

Bug or feature? Perhaps the heart of matter lies with tabs configured via JSON. Regardless, hopefully this can help others.

halftrainedharry · November 30, 2021, 10:56pm

You should be able to fix this bug by changing the following line in the chunk “npTabsJsTpl” (in the manager)

github.com

BobRay/newspublisher/blob/c8cda5a2d82be5979904bbfefbf965f74e9492b1/core/components/newspublisher/elements/chunks/nptabsjs.chunk.tpl#L61

    
      
          
          
/* *************
           the code
          ************** */
          
          
/* by default no filter button is selected */
          var jsonFieldsCount = 0; /* used to determine if "Other" option is shown */
          var hasFilterSelected = false;
          
          
$.each(buttonsJson, function(buttonName, aFields) {
             var buttonClass = buttonPrefixClass + buttonName; /* criterion for filtering items */
             var aClass = '';
             if (activeButton==buttonName.toLowerCase()){ /* if button label matches to activeButton property */
               aClass = filterSelected;
               hasFilterSelected = true;
             }
             htmlButtons += '<li id="np-buttons"><a class="' +  aClass  + '" data-filter=".' + buttonClass + '" href="#">' + buttonName + '</a></li>';
             $.each(aFields, function(index, fieldName) {
              /* find that element by name (name can be fieldName or fieldName[]) */
              var field = $('[name^="' + fieldName + '"]:last');
              if (field.length > 0){

to this:

var buttonClass = buttonPrefixClass + buttonName.replace(' ', '-'); /* criterion for filtering items */

wpicotte · December 2, 2021, 7:08pm

That did the trick – thank you!