VersionX and MODX 3.0.1-pl - chunks and snippets versions not saved

dejaya · July 1, 2022, 8:46pm

Hi all … sorry, me again

I’ve checked against four different MODX 3.0.1-pl sites and all of them fail to save new versions [via VersionX] when Chunks or Snippets are saved.

Resource versions are saved OK.

When saving a Chunk or Snippet - one or more of the following errors are logged:

[2022-07-01 20:15:05] (ERROR @ /home/xxyyzz/core/components/versionx/model/versionx.class.php : 318) PHP warning: Object of class MODX\Revolution\mysql\modSnippet could not be converted to int
[2022-07-01 20:15:21] (ERROR @ /home/xxyyzz/core/components/versionx/model/versionx.class.php : 279) PHP warning: Object of class MODX\Revolution\mysql\modChunk could not be converted to int
[2022-07-01 20:15:21] (ERROR @ /home/xxyyzz/core/components/versionx/elements/plugins/versionx.plugin.php : 117) undefined error

Can anyone reproduce this?

VersionX is up to date. All sites on PHP 8.1.

markh · July 1, 2022, 8:52pm

Could you log an issue at Issues · modmore/VersionX · GitHub please? There is some type checking going on that needs to be updated I guess.

dejaya · July 1, 2022, 8:55pm

Of course @markh — will do.

halftrainedharry · July 1, 2022, 9:11pm

You probably just have to add the namespace to the classes modChunk and modSnippet.

if ($chunk instanceof \MODX\Revolution\modChunk) { instead of if ($chunk instanceof modChunk) {

github.com

modmore/VersionX/blob/ea8a61c59867145e56b628c3fa638c5a19b723e4/core/components/versionx/model/versionx.class.php#L275


      
              return true;
          }
          /**
           * Create a new version of a Chunk.
           *
           * @param int|\modChunk $chunk
           * @param string $mode
           * @return bool
           */
          public function newChunkVersion($chunk, $mode = 'upd') {
              if ($chunk instanceof modChunk) {
                  /* Fetch it again to prevent getting stuck with raw post data */
                  $chunk = $this->modx->getObject('modChunk', $chunk->get('id'));
              } else {
                  $chunk = $this->modx->getObject('modChunk', (int)$chunk);
              }
          
          
    // prevents resource groups from failing in MODX versions prior to 2.2.14 (see github #8992 + fix)
              if (!($chunk instanceof modChunk)) {
                  return false;
              }

github.com

modmore/VersionX/blob/ea8a61c59867145e56b628c3fa638c5a19b723e4/core/components/versionx/model/versionx.class.php#L314


      
          }
          
          
/**
           * Creates a new version of a Snippet.
           *
           * @param int|\modSnippet $snippet
           * @param string $mode
           * @return bool
           */
          public function newSnippetVersion($snippet, $mode = 'upd') {
              if ($snippet instanceof modSnippet) {
                  /* Fetch it again to prevent getting stuck with raw post data */
                  $snippet = $this->modx->getObject('modSnippet', $snippet->get('id'));
              } else {
                  $snippet = $this->modx->getObject('modSnippet', (int)$snippet);
              }
          
          
    $sArray = $snippet->toArray();
          
          
    /* @var vxSnippet $version */
              $version = $this->modx->newObject('vxSnippet');

dejaya · July 1, 2022, 9:30pm

Hey @halftrainedharry …

That looks like a fix to me.

Line 275 as you suggested:

if ($chunk instanceof \MODX\Revolution\modChunk) {

Line 314:

if ($snippet instanceof \MODX\Revolution\modSnippet) {

Both chunks and snippets saving versions as they should now

Issue raised here.

halftrainedharry · July 1, 2022, 9:46pm

By the way, thanks for testing all these extras in MODX 3.

dejaya · July 1, 2022, 10:27pm

All good @halftrainedharry … I’d have liked to have been able to test more pre MODX 3 launch but it just wasn’t possible for me back then.

I’m always hugely grateful for the community’s help

markh · July 1, 2022, 10:34pm

Yeah, that’s the fix that’s needed across all element types, though as for now the modmore policy is to keep extras both 2.x and 3.x compatible from the same codebase (if at all possible, MoreGallery has been… interesting), we usually it like this:

if ($chunk instanceof \MODX\Revolution\modChunk || $chunk instance of modChunk) {

dejaya · July 1, 2022, 10:44pm

Aye … the modmore policy is good!

Line 275:

if ($chunk instanceof \MODX\Revolution\modChunk || $chunk instanceof modChunk) {

Line 314:

if ($snippet instanceof \MODX\Revolution\modSnippet || $snippet instanceof modSnippet) {

Tested

bobray · July 7, 2022, 4:44am

I wish I’d thought of that. I’ve been removing instanceof calls from my extras, on the assumption that MODX will return null if it can’t get the requested object.

markh · July 10, 2022, 4:30pm

That also works. Technically the odds of any getObject returning an object that is not the type you ask for is pretty much impossible, so they’d be equivalent in any but super weird edge cases that don’t happen unless you specifically make them happen to prove the point.