Output of image path with pdoResources and MODX 3.0.1

seliin · July 13, 2022, 6:35am

Hi
I use MODX 3.0.1 and pdoResources with a TV Variable “project_teaser_img”.
I set the parameter processTVs to 1 and defined a Media Source.
The image output is without the path I specified on the media sources.

With MODX version 2.8.x this always worked.

Thank you very much for help

dejaya · July 13, 2022, 8:20am

Hi @seliin

This actually happened to me last night.

I upgraded a site from 2.8.4-pl to 3.0.1-pl and I got a front-end page full of broken images.

The problem was as you described, the image output no longer included the Media Source path.

This only happened in one place, so I quick-fixed it by just adding the missing path in the template before the image call.

However I’d be interested to find out what the cause for this is. I’ll try to troubleshoot it properly myself if I get time - but would welcome anyone else’s thoughts on it.

halftrainedharry · July 13, 2022, 9:38am

It seems to work correctly when you list the TV in the processTV property → &includeTVs=`myImgTV`
But &processTVs=`1` doesn’t work.

The problem is this line in the code that should use == instead of ===

github.com

modx-pro/pdoTools/blob/3a358ecee89963c8718fd6537f0ad44dec87bfe6/core/components/pdotools/src/CoreTools.php#L905


      
          {
              $time = microtime(true);
              $prepare = $process = $prepareTypes = [];
              if (!empty($this->config['includeTVs']) && (!empty($this->config['prepareTVs']) || !empty($this->config['processTVs']))) {
                  $tvs = array_map('trim', explode(',', $this->config['includeTVs']));
                  $prepare = ($this->config['prepareTVs'] === 1)
                      ? $tvs
                      : array_map('trim', explode(',', $this->config['prepareTVs']));
                  $prepareTypes = array_map('trim',
                      explode(',', $this->modx->getOption('manipulatable_url_tv_output_types', null, 'image,file')));
                  $process = ($this->config['processTVs'] === 1)
                      ? $tvs
                      : array_map('trim', explode(',', $this->config['processTVs']));
          
          
        $prepare = array_flip($prepare);
                  $prepareTypes = array_flip($prepareTypes);
                  $process = array_flip($process);
              }
          
          
    foreach ($rows as & $row) {
                  // Extract JSON fields

$process = ($this->config['processTVs'] == 1)
//or
$process = ($this->config['processTVs'] === "1")

dejaya · July 13, 2022, 10:22am

Thanks @halftrainedharry

Specifying the TVs explicitly as:

&includeTVs=`myImgTV-1,myImgTV-2`
&processTVs=`myImgTV-1,myImgTV-2`

fixed the problem for me.

I don’t see this raised as an issue for PdoTools - happy to add it.

halftrainedharry · July 13, 2022, 10:39am

I created a pull request.