Darn. What else can I do to diagnose this? My daughter is already desperate to get her site up and running again… (and I was the one to tell her “always do the updates”… sigh)
Btw, the MODX Updater suggests to update to MODX 3.0.1-DEV (shown red). Should we do that?
Is it possible to make a fresh MODX3 installation on the same environment (maybe in a subfolder or a subdomain), to check if this is a general problem (on this environment) or if something is just corrupted on your current installation?
I don’t think this is an official release. So an update may not be a great idea.
It will be faster and it should avoid any possible nesting, cache, or interference issues, though it doesn’t help determine whether or not you’ve discovered a bug in MODX 3.
In the last 3 months, most problems related to MODX 3 and the parser were caused by a change in how output modifiers are parsed. So although your problem seems to be different, maybe try changing this line in the code
to this (how it was in MODX 2.x)
if (preg_match_all('~:([^:=]+)(?:=`(.*?)`[\r\n\s]*(?=:[^:=]+|$))?~s', $modifiers, $matches)) {
@halftrainedharry: Wow, your proposed change actually worked! Thanks a bundle.
I changed /core/src/Revolution/Filters/modInputFilter.php as proposed, had to clear MODX’ cache and voilà—all back to good!
Being a change in core, we now of course fear it might be overwritten with the next update. Maybe this could also be tested by others and possible (re-)included in the release?
I still feel a little uneasy about marking a solution here, for fear it might “go under” and not been officially fixed in core—possibly leading to a future upgrade overwriting the core change and breaking the sites again.
Personally, I’m not deep enough into MODX to see what side effects reverting PR #14458 actually might have, and what kind of tests would have to be written to ensure it works correctly. Then again, it seems the previous code has been working fine over years and years (and the change back solved our problems here), so I’d opt for reverting it back—ideally in a way that maybe also fixes the problem the PR was originally written for.
Unfortunately, this is currently all a little over my head, being more of a happy longtime user of “the best” CMS, after years of evaluating others. So what can we do to ensure the best possible experience for all MODXers with this issue?
Oh, and heartfelt thanks from my daughter (who silently follows this thread)—she was really impressed how problems are handled and solutions generated here in the MODX community. She actually borrowed all my MODX books on her last visit, and started following Bob’s Guides. (Love my kids! Maybe time to hand things over to the next generation, hee hee…)