After upgrading to 3.x, log filled with listbox errors

snowcreative · February 19, 2026, 9:56pm

I just noticed in a 3.1.x site, the log is filling with this error:

[2026-02-19 10:20:00] (ERROR @ …/core/src/Revolution/Processors/Element/TemplateVar/Renders/mgr/input/listbox-multiple.class.php : 80) PHP warning: Undefined array key “preserveSelectionOrder”

I had to resave all my listbox-multiple TVs so that the new TV settings would get added the input_properties field. Shouldn’t this happen in the process of upgrading from 2.x to 3.x?

smashingred · February 20, 2026, 2:17pm

@snowcreative did you report this as a bug? GitHub · Where software is built

Do you have any more details?

halftrainedharry · February 20, 2026, 2:42pm

This is not a problem of “upgrading from 2.x to 3.x”. The same functionality was added to both the 2.x and the 3.x branch a bit more than a year ago. So you should also see the same warnings, if you upgrade from 3.0.x to 3.1.x.

Yes, ideally there would be a script that runs on the upgrade to add the missing input properties.
Or a check in the code, that tests the availability of the array key before accessing it:

github.com/modxcms/revolution

core/src/Revolution/Processors/Element/TemplateVar/Renders/mgr/input/listbox-multiple.class.php

372fedd2a


      
                              'text' => $customValue,
                              'value' => $customValue,
                              'selected' => 1
                          ];
                      }
                      $selections = array_merge($selections, $customData);
                  }
              }
              $items = array_merge($selections, $items);
          
              if ($params['preserveSelectionOrder']) {
                  $this->reorderBySelectionOrder($savedValues, $items);
              }
          
              $this->setPlaceholder('opts', $items);
          }
          
          private function reorderBySelectionOrder(array $selections, array &$items)
          {
              $itemsValues = array_column($items, 'value');
              $orderedSelections = [];

But the issue isn’t critical, as the code should still run correctly.

This issue is also quite similar to your older thread here:

snowcreative · February 21, 2026, 8:53pm

Wow, totally didn’t remember that I flagged this before. I don’t think I thought to resave all the listbox TVs to fix the problem at that time.