Absolute / relative image paths in PDFResource

halftrainedharry · October 10, 2024, 9:52am

Looking at the mPDF documentation for the function SetBasePath(), it says that

From mPDF 5.7 the HTML tag <base href=""> is parsed in the HTML and used to set the base path.

But testing the PDFResource extra, this doesn’t seem to be the case.

When I change the code though, and add the line

$this->pdf->setBasePath($this->modx->getOption('site_url'));

here (on line 289 before WriteHTML() is called)

github.com

Jako/PDFResource/blob/0ce000a459e6c00474b2bf093fdde04d5a29fb75/core/components/pdfresource/src/PDFResource.php#L289


      
          // Call additional mPDF methods
          $mpdfMethods = json_decode($this->getOption('mPDFMethods', $pdfOptions, ''), true);
          $mpdfMethods = (is_array($mpdfMethods)) ? $mpdfMethods : [];
          foreach ($mpdfMethods as $methodName) {
              $value = $this->getOption($methodName, $pdfOptions, '');
              $value = (is_array($value)) ? $value : json_decode($value, true);
              if ($value && method_exists($this->pdf, $methodName)) {
                  call_user_func_array([$this->pdf, $methodName], $value);
              }
          }
          
          $this->pdf->WriteHTML($css, 1);
          $this->pdf->WriteHTML($html, 2);
          
          if (!is_null($aliasPath)) {
              return $this->pdf->Output($this->getOption('pdfPath') . $aliasPath . $resource->get('alias') . '.pdf', 'F');
          } else {
              header('Content-Type: application/pdf');
              header('Content-Disposition:inline;filename=' . $resource->get('alias') . '.pdf');
              echo $this->pdf->Output('', 'S');
              @session_write_close();

the images get added correctly to the PDF file.

I also tried altering the chunk “tplPDF” to include <base href="[[!++site_url]]"> in the <head>, but that doesn’t seem to work.